Change in ovirt-engine[master]: core: unregister libvirt secrets on host disconnect

derez at redhat.com derez at redhat.com
Wed Nov 11 14:59:41 UTC 2015


Daniel Erez has submitted this change and it was merged.

Change subject: core: unregister libvirt secrets on host disconnect
......................................................................


core: unregister libvirt secrets on host disconnect

On 36324ffa6576c3641358f5ef52015fb1bc532cb2, secrets unregistration logic
was removed from DisconnectHostFromStoragePoolServersCommand based on the
assumption that a storage_server_connection should exist for all
storage domains. However, no connection is created for Cinder domains,
hence, unregistration should be invoked directly.
[similar to https://gerrit.ovirt.org/#/c/47924/]

Change-Id: Ibfecbc326c6787ecdf8f72abf4997c1821ad62bf
Bug-Url: https://bugzilla.redhat.com/1279499
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServerCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectHostFromStoragePoolServersCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/RegisterLibvirtSecretsVDSParameters.java
3 files changed, 15 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Daniel Erez: Verified
  Maor Lipchuk: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/48304
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfecbc326c6787ecdf8f72abf4997c1821ad62bf
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list