Change in ovirt-engine[master]: core: dao: multiple results per type

amureini at redhat.com amureini at redhat.com
Fri Nov 13 15:08:10 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: dao: multiple results per type
......................................................................


core: dao: multiple results per type

Renamed
StorageDomainDao#getStorageDomain(Guid, StorageDomainType, StorageDomainStatus)
and StorageDomainDao#getStorageDomain(Guid, StorageDomainType) to
getStorageDomains and changed the return type to List<StorageDomain>,
as, in the common case (i.e., a data domain), a pool can have multiple
domains of a given type.

Change-Id: I39590d066dde8f3e37f414b3298edc82191b6a59
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDaoTest.java
5 files changed, 29 insertions(+), 30 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified
  Idan Shaby: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/48279
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I39590d066dde8f3e37f414b3298edc82191b6a59
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list