Change in ovirt-engine-cli[master]: cli: Process correct "--parent..." options

juan.hernandez at redhat.com juan.hernandez at redhat.com
Thu Nov 19 09:12:12 UTC 2015


Juan Hernandez has submitted this change and it was merged.

Change subject: cli: Process correct "--parent..." options
......................................................................


cli: Process correct "--parent..." options

Currently when the CLI tries to find a parent collection it assumes that
the option used is "--type-identifier", but it can also be
"--parent-type-identifier" and "--parent-type-name". As a result when
the "--parent..." options are used autocompletion doesn't show the
correct options. To avoid this issue this patch changes the CLI so that
it uses the methods that check this in a more generic way.

Change-Id: I42fb362c59d4baad5968c1ac0df15bbe0b7dab8a
Bug-Url: https://bugzilla.redhat.com/1282832
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M Makefile
M src/ovirtcli/command/command.py
M src/ovirtcli/shell/cmdshell.py
3 files changed, 23 insertions(+), 51 deletions(-)

Approvals:
  Ori Liel: Looks good to me, but someone else must approve
  Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/48676
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I42fb362c59d4baad5968c1ac0df15bbe0b7dab8a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ori Liel <oliel at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list