Change in ovirt-engine[master]: core: Changed NATURAL INNER JOIN to NATURAL JOIN

emesika at redhat.com emesika at redhat.com
Mon Nov 23 07:35:45 UTC 2015


Eli Mesika has submitted this change and it was merged.

Change subject: core: Changed NATURAL INNER JOIN to NATURAL JOIN
......................................................................


core: Changed NATURAL INNER JOIN to NATURAL JOIN

The create_views sql script is using "NATURAL INNER JOIN" views which
practically behaves the same as "NATURAL JOIN" and is also confusing
for anyone looking at the code. It's also not commonly used
in code bases.

For that reason, all views using "NATURAL INNER JOIN" now use
"NATURAL JOIN" instead.

Change-Id: I95e197312cc506c2aaa94c8c5532c09c9faf7f9a
Bug-Url: https://bugzilla.redhat.com/1143869
Signed-off-by: Tomer Saban <tsaban at redhat.com>
---
M packaging/dbscripts/create_views.sql
1 file changed, 11 insertions(+), 11 deletions(-)

Approvals:
  Eli Mesika: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Tomer Saban: Verified



-- 
To view, visit https://gerrit.ovirt.org/48934
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I95e197312cc506c2aaa94c8c5532c09c9faf7f9a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomer Saban <tsaban at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list