Change in ovirt-engine[master]: core: VmValidator#vmNotHavingPassthroughVnics linq

amureini at redhat.com amureini at redhat.com
Mon Nov 23 09:01:32 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: VmValidator#vmNotHavingPassthroughVnics linq
......................................................................


core: VmValidator#vmNotHavingPassthroughVnics linq

Replaced the usage of LinqUtils with a single fluent call to Java 8's
streaming API.

This patch both simplifies the code and offers a slight performance
boost since the list of interfaces is only iterated once, instead of
twice in the original code (once for filtering the passthrough nics and
once for extracting their Names with ReplacementUtils).

Change-Id: Ibb009e2c2e604a740712987fd35763c578f2b36c
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java
1 file changed, 7 insertions(+), 9 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified
  Arik Hadas: Looks good to me, approved
  Yevgeny Zaspitsky: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/48891
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb009e2c2e604a740712987fd35763c578f2b36c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list