Change in ovirt-engine[master]: core: Remove the Findbugs profiles

juan.hernandez at redhat.com juan.hernandez at redhat.com
Mon Nov 23 09:15:42 UTC 2015


Juan Hernandez has submitted this change and it was merged.

Change subject: core: Remove the Findbugs profiles
......................................................................


core: Remove the Findbugs profiles

Currently we have two Maven profiles related to Findbugs, one named
"findbugs" that adds the project specific exclussions, and another one
named "findbugs-general" that also adds the shared exclussions. As both
exclussions need to be always enabled these profiles aren't needed,
instead the required settings can be specified in the Findbugs plugin,
inside the "plugins" section of the root POM.

After applying this patch the invocation of Findbugs will just be the
following:

  $ mvn findbugs:findbugs

The "-Pfindbugs-general" option is no longer required.

Change-Id: Ife1fafa2b6b7db4ee12d61835319059396a1f68e
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M pom.xml
1 file changed, 20 insertions(+), 56 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
  Oved Ourfali: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/48687
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ife1fafa2b6b7db4ee12d61835319059396a1f68e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk at redhat.com>
Gerrit-Reviewer: David Caro <dcaro at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Sharon Naftaly <snaftaly at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list