Change in ovirt-engine[master]: core: 'revert' of 2f471d83d145d7bc6674c6039bf7f8d1ba9ed137

alkaplan at redhat.com alkaplan at redhat.com
Tue Nov 24 07:47:04 UTC 2015


Alona Kaplan has submitted this change and it was merged.

Change subject: core: 'revert' of 2f471d83d145d7bc6674c6039bf7f8d1ba9ed137
......................................................................


core: 'revert' of 2f471d83d145d7bc6674c6039bf7f8d1ba9ed137

patch 2f471d83d145d7bc6674c6039bf7f8d1ba9ed137 was entirelly wrong.
One must not consult macPool there, since interface here already has
MAC address obtained from pool, so check here always failed.

It probably cannot be reverted nicely, since there were other patches
fixing some of problems this patch introduced.

note: bug 
https://bugzilla.redhat.com/show_bug.cgi?id=1212461
related to patch being reverted, was reverified as well and I did not reproduce it.


Change-Id: I0c3b9f9a4cb2f8515823d42293a7928485f4cedf
Bug-Url: https://bugzilla.redhat.com/1270583
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
1 file changed, 6 insertions(+), 31 deletions(-)

Approvals:
  Martin Mucha: Verified
  Alona Kaplan: Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/47899
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0c3b9f9a4cb2f8515823d42293a7928485f4cedf
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list