Change in ovirt-engine[master]: core: StorageServerConnectionLunMapDaoImpl#getAll(String)

[amureini at redhat.com]

Allon Mureinik has submitted this change and it was merged.

Change subject: core: StorageServerConnectionLunMapDaoImpl#getAll(String)
......................................................................


core: StorageServerConnectionLunMapDaoImpl#getAll(String)

The getAll(String lunId) method was implemented naively be retrieving
all the rows from the table and then filtering them in memory.

This patch replaces this implementation by a proper stored procedure
implementation which is both easier to read, and potentially performs
better on large tables by leaving the filtering logic to the database
instead of transferring the entire table to the engine's memory and
having to filter there.

Change-Id: Ied9fbe3e427f37be604ae7d2fec58962f38cba22
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionLunMapDaoImpl.java
M packaging/dbscripts/storages_san_sp.sql
2 files changed, 19 insertions(+), 9 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests
  Ala Hino: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/49066
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ied9fbe3e427f37be604ae7d2fec58962f38cba22
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>