Change in ovirt-engine[master]: core: StorageServerConnectionLunMapDaoImpl#getAll()

amureini at redhat.com amureini at redhat.com
Wed Nov 25 16:51:52 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: StorageServerConnectionLunMapDaoImpl#getAll()
......................................................................


core: StorageServerConnectionLunMapDaoImpl#getAll()

Before this patch, getAll() was not implemented (it just threw a
NotImplementedException), while the private
getAllLUNStorageServerConnection method returned all the rows in the
table.

This patch standardized the StorageServerConnectionLunMapDaoImpl by
removing this private method and moving its implementation to the
standard getAll() method instead.

Change-Id: I94feec8f713b43982931794e468e1365260c65b2
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionLunMapDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionLunMapDaoTest.java
2 files changed, 11 insertions(+), 8 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/49065
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I94feec8f713b43982931794e468e1365260c65b2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list