Change in ovirt-engine[master]: core: Test AddVdsSpmIdCommand#insertSpmIdToDb

amureini at redhat.com amureini at redhat.com
Wed Nov 25 16:51:54 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Test AddVdsSpmIdCommand#insertSpmIdToDb
......................................................................


core: Test AddVdsSpmIdCommand#insertSpmIdToDb

Introduced a simple test case for the insertSpmIdToDb method.
It receives a list of existing vds_spm_ids and verifies that the correct
new one is inserted into the mocked database.

Change-Id: I1c77c1a0d732d0c7351449bddf5bde1e85aba70a
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommand.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommandTest.java
2 files changed, 73 insertions(+), 1 deletion(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests
  Ala Hino: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/49040
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1c77c1a0d732d0c7351449bddf5bde1e85aba70a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list