Change in ovirt-engine[master]: core: AddVmFromScratchCommand streaming API

amureini at redhat.com amureini at redhat.com
Thu Nov 26 16:15:04 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: AddVmFromScratchCommand streaming API
......................................................................


core: AddVmFromScratchCommand streaming API

Replace outdate LinqUtils calls with Java 8's streaming API. Besides
improving the code, this patch offers a slight performance benefit by
using the short-circuit terminator findFirst which returns the first
domain to satisfy the condition instead of having to iterate all of them
just to retrieve the ID of the first one.

Change-Id: I3bae8b6f5b6626a76971082c0a8b4e678532c26e
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java
1 file changed, 5 insertions(+), 12 deletions(-)

Approvals:
  Allon Mureinik: Verified; Passed CI tests
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/48957
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3bae8b6f5b6626a76971082c0a8b4e678532c26e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list