Change in ovirt-engine[ovirt-engine-3.6.1]: webadmin: prevent an npe on VmSnapshotListModel

tnisan at redhat.com tnisan at redhat.com
Mon Nov 30 16:45:03 UTC 2015


Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: prevent an npe on VmSnapshotListModel
......................................................................


webadmin: prevent an npe on VmSnapshotListModel

VmSnapshotListModel -> updateIsCloneVmSupported:
Setting 'vm' variable as final to re-use inside
the AsynQuery. This would prevent a possible
NPE when 'model.getEntity()' returns null.

Change-Id: Ic6cde19e46bc3c4f99f7a80d194869f32990ed86
Bug-Url: https://bugzilla.redhat.com/1286658
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved; Passed CI tests
  Daniel Erez: Verified



-- 
To view, visit https://gerrit.ovirt.org/49457
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6cde19e46bc3c4f99f7a80d194869f32990ed86
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.1
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list