Change in ovirt-engine[master]: webadmin: Re-selection of the same icon works in IE and Chrome

tjelinek at redhat.com tjelinek at redhat.com
Thu Oct 1 14:02:12 UTC 2015


Tomas Jelinek has submitted this change and it was merged.

Change subject: webadmin: Re-selection of the same icon works in IE and Chrome
......................................................................


webadmin: Re-selection of the same icon works in IE and Chrome

In IE and Chrome <input type="file"> only fires 'change' event if the
new files selection differes from the previous selection. This behaviour
causes that one can't 1. select custom icons, 2. use default icon, 3.
re-select the same custom icon

The solution is creating new <input> tag for each upload invocation.

Change-Id: I8455c45c5126409d37d3469d0b67a1c752c94f40
Bug-Url: https://bugzilla.redhat.com/1267711
Signed-off-by: Jakub Niedermertl <jniederm at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/IconEditorWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/IconEditorWidget.ui.xml
2 files changed, 17 insertions(+), 18 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Jakub Niedermertl: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/46895
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8455c45c5126409d37d3469d0b67a1c752c94f40
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list