Change in ovirt-engine[master]: engine : Can't remove vm template - the disks are removed an...

masayag at redhat.com masayag at redhat.com
Tue Oct 20 04:40:53 UTC 2015


Moti Asayag has submitted this change and it was merged.

Change subject: engine : Can't remove vm template - the disks are removed and the template stays locked
......................................................................


engine : Can't remove vm template - the disks are removed and the template stays locked

The patch Ib3261800f383a6e3973acab4bd1 caused regression
in commands that ran Async Tasks.

This patch reverts the changes in CommandBase related to
AsyncTasks and implements a simpler solution using
existing shouldBeEndedByParent flag in VdcActionParametersBase.

Change-Id: I41f318c8fbef94d3d125d2ca80d687cb27195667
Bug-Url: https://bugzilla.redhat.com/1273094
Signed-off-by: Ravi Nori <rnori at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java
2 files changed, 16 insertions(+), 81 deletions(-)

Approvals:
  Ravi Nori: Verified
  Jenkins CI: Passed CI tests
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/47489
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I41f318c8fbef94d3d125d2ca80d687cb27195667
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list