Change in ovirt-engine[master]: Improve error message when OVF cannot be parsed from export ...

shavivi at redhat.com shavivi at redhat.com
Tue Oct 20 11:23:47 UTC 2015


Shahar Havivi has submitted this change and it was merged.

Change subject: Improve error message when OVF cannot be parsed from export domain
......................................................................


Improve error message when OVF cannot be parsed from export domain

When we fail to read ovf from export domain we give none informative
error message.
This patch record last entry that we try to read and in a case of an
error we point to the entry we tried to read and for the invalid value.

Bug-Url: https://bugzilla.redhat.com/1261951
Change-Id: I6405feee1f8ced126f4329602779339b1f9abf44
Signed-off-by: Shahar Havivi <shaharh at redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfManager.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReaderException.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java
5 files changed, 231 insertions(+), 168 deletions(-)

Approvals:
  Shahar Havivi: Verified
  Jenkins CI: Passed CI tests
  Omer Frenkel: Looks good to me, but someone else must approve
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/47448
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6405feee1f8ced126f4329602779339b1f9abf44
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list