Change in ovirt-engine[ovirt-engine-3.6]: core: CreateCinderSnapshot failure flow - fix NPE

tnisan at redhat.com tnisan at redhat.com
Wed Oct 21 08:54:59 UTC 2015


Tal Nisan has submitted this change and it was merged.

Change subject: core: CreateCinderSnapshot failure flow - fix NPE
......................................................................


core: CreateCinderSnapshot failure flow - fix NPE

CreateCinderSnapshotCommandCallback -> onFailed:
'getDiskId' method shouldn't be invoked before setting
the 'cmdId' (to avoid an NPE on getCommand).

Change-Id: I5a95af5f7999e33a638a00348b269c35c3972ce4
Bug-Url: https://bugzilla.redhat.com/1273572
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CreateCinderSnapshotCommandCallback.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Daniel Erez: Verified
  Jenkins CI: Passed CI tests
  Maor Lipchuk: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/47540
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5a95af5f7999e33a638a00348b269c35c3972ce4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list