Change in ovirt-engine[ovirt-engine-3.6]: core: Avoid NPE when validating non-LUN disks

tnisan at redhat.com tnisan at redhat.com
Tue Sep 8 13:57:10 UTC 2015


Tal Nisan has submitted this change and it was merged.

Change subject: core: Avoid NPE when validating non-LUN disks
......................................................................


core: Avoid NPE when validating non-LUN disks

In some scenarios, such as import a non-existing VM, a validation may be
applied to a non-existing disk. These cases are legal and don't need the
verification. The validation is sometimes needed in an internal command,
hence the best way is to ignore it when it's not needed.

Change-Id: I0024da114c56e0520421a5e138c6c9e49cf278b9
Bug-Url: https://bugzilla.redhat.com/1147860
Signed-off-by: Vered Volansky <vvolansk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CopyImageGroupCommand.java
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Tal Nisan: Passed CI tests
  Daniel Erez: Looks good to me, approved
  Vered Volansky: Verified



-- 
To view, visit https://gerrit.ovirt.org/45855
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0024da114c56e0520421a5e138c6c9e49cf278b9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list