Change in ovirt-hosted-engine-ha[master]: Do not start services, let systemd take care of that

msivak at redhat.com msivak at redhat.com
Wed Sep 9 11:25:10 UTC 2015


Martin Sivák has submitted this change and it was merged.

Change subject: Do not start services, let systemd take care of that
......................................................................


Do not start services, let systemd take care of that

RHEL 6 did not have any proper service monitoring and so we did
it by ourselves. RHEL 7 is the only supported system now and we
have systemd available so now we have two programs that are trying
to monitor and restart vdsmd and sanlock (us and systemd).

This causes trouble when there is a valid reason for keeping them
down - like during upgrade - and so this patch changes the behaviour
to just monitor and wait.

No services will be started by the agent, the fact that something
is not running will be logged and the agent will try later. This
won't increment the FSM error counters either so the agent won't
ever quit while waiting (unless stopped properly or killed by
other error).

Change-Id: I1178aff984d68739e3d42b582589d376b56f45c1
Signed-off-by: Martin Sivak <msivak at redhat.com>
---
M initscripts/ovirt-ha-agent.service
M ovirt_hosted_engine_ha/agent/hosted_engine.py
2 files changed, 41 insertions(+), 22 deletions(-)

Approvals:
  Sandro Bonazzola: Looks good to me, but someone else must approve
  Martin Sivák: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/45842
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1178aff984d68739e3d42b582589d376b56f45c1
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list