Change in ovirt-engine[master]: core: fix graphics on import

ofrenkel at redhat.com ofrenkel at redhat.com
Thu Sep 10 06:47:52 UTC 2015


Omer Frenkel has submitted this change and it was merged.

Change subject: core: fix graphics on import
......................................................................


core: fix graphics on import

1. restore display type values:
the values for cirrus (vnc) and qxl changed, this breaks backward
compatibility with previously exported vms, so restored to original
values.

2. the code that create graphics device on import was called too soon,
and device was removed while reloading the vm from export domain during
canDoAction, so moved the call to a better place.

3. fixed that code to select spice for qxl, if os support it, to match
the previous values in the engine (qxl was always spice)

Change-Id: I3fd8351a3f18428cfe905a39221756608b64da05
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1261446
Signed-off-by: Omer Frenkel <ofrenkel at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportUtils.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DisplayType.java
A packaging/dbscripts/upgrade/03_06_1830_fix_display_type_numbers.sql
4 files changed, 19 insertions(+), 7 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Frank Kobzik: Looks good to me, but someone else must approve
  Omer Frenkel: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/45941
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3fd8351a3f18428cfe905a39221756608b64da05
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list