Change in ovirt-engine[master]: webadmin: override getConsumedEvents of CheckboxCell

derez at redhat.com derez at redhat.com
Thu Sep 17 07:19:33 UTC 2015


Daniel Erez has submitted this change and it was merged.

Change subject: webadmin: override getConsumedEvents of CheckboxCell
......................................................................


webadmin: override getConsumedEvents of CheckboxCell

SanStorageLunToTargetList -> addSelectAllButton:
update method on the custom ValueUpdater isn't get invoked
since CheckboxCell's parent events are overridden on
CheckboxCell -> getConsumedEvents (see [1]).
Hence, adding parent's consumedEvents on SanStorageLunToTargetList.

[1] https://gerrit.ovirt.org/#/c/45444/

Change-Id: Iea76bc58689d608e83554072e871487dc33fb4d8
Bug-Url: https://bugzilla.redhat.com/1215416
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/CheckboxCell.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java
2 files changed, 13 insertions(+), 1 deletion(-)

Approvals:
  Alexander Wels: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Daniel Erez: Verified



-- 
To view, visit https://gerrit.ovirt.org/45953
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iea76bc58689d608e83554072e871487dc33fb4d8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list