Change in ovirt-engine[master]: engine: Introduce AsserJ for test assertions

sbonazzo at redhat.com sbonazzo at redhat.com
Fri Sep 18 08:57:58 UTC 2015


Sandro Bonazzola has submitted this change and it was merged.

Change subject: engine: Introduce AsserJ for test assertions
......................................................................


engine: Introduce AsserJ for test assertions

AssertJ is a very useful assertion library which has the extra
advantages of full autocomplete support in your favourite IDE with
fluent and very readable assertions.

Examples:

  assertThat(list).isNotNull().isEmpty();
  assertThat(list).hasSize(15).contains(1,2).doesNotContain(5)
  assertThat(listA).hasSameSizeAs(listb)
  assertThat(objectA).isEqualTo(objectB)
  assertThat(objectA).isSameAs(objectB)
  ...

It is also easy to create domain specific assertions which can be used
the same way. See http://joel-costigliola.github.io/assertj/ for further
details.

Change-Id: I750249be3e966b721be6a6a56a1d3a281c312179
Signed-off-by: Roman Mohr <rmohr at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcerTest.java
M ovirt-engine.spec.in
M pom.xml
3 files changed, 21 insertions(+), 16 deletions(-)

Approvals:
  Sandro Bonazzola: Looks good to me, approved
  Roman Mohr: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/45980
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I750249be3e966b721be6a6a56a1d3a281c312179
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list