Change in ovirt-engine[ovirt-engine-3.6]: webadmin: check box header

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Tue Sep 22 07:30:47 UTC 2015


Piotr Kliczewski has submitted this change and it was merged.

Change subject: webadmin: check box header
......................................................................


webadmin: check box header

- The ResizeableCheckboxHeader was not propagating the
  'change' event handling causing some header check boxes
  to not react to changes. This patch fixes the issue.
  Unfortunately I have to 'polute' the ResizableHeader to
  handle change as constructor is the only place that allows
  one to pass in the checkbox that handles the event. This
  means that the method that creates the checkbox has to be
  static, and you can't override a static method.

Change-Id: Ib302582c57055705c7348112d99b49f5ec6a8841
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1257168
Signed-off-by: Alexander Wels <awels at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/ResizableHeader.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/ResizeableCheckboxHeader.java
2 files changed, 1 insertion(+), 18 deletions(-)

Approvals:
  Alexander Wels: Verified
  Jenkins CI: Passed CI tests
  Greg Sheremeta: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/46462
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib302582c57055705c7348112d99b49f5ec6a8841
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list