Change in ovirt-engine[master]: restapi: Replace CPU "id" attribute with "type" element

juan.hernandez at redhat.com juan.hernandez at redhat.com
Tue Sep 22 10:03:18 UTC 2015


Juan Hernandez has submitted this change and it was merged.

Change subject: restapi: Replace CPU "id" attribute with "type" element
......................................................................


restapi: Replace CPU "id" attribute with "type" element

Current the "cpu" element has an "id" attribute that indicates the type
of CPU:

  <cpu id="Intel Conroe Family">
    <architecture>X86_64</architecture>
    ...
  </cpu>

This is in contradiction with the rest of the elements of the RESTAPI
model, where the "id" attribute is used for opaque identifiers. This
patch replaces the "id" attribute with a new "type" element:

  <cpu>
    <type>Intel Conroe Family</type>
    <architecture>X86_64</architecture>
    ...
  </cpu>

Change-Id: I54d7f270832370b324e92521ca8b659e84a593c6
Bug-Url: https://bugzilla.redhat.com/1259620
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/modules/restapi/README.md
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCapabilityResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendClustersResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterClustersResourceTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/ClusterMapperTest.java
10 files changed, 34 insertions(+), 14 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/45996
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I54d7f270832370b324e92521ca8b659e84a593c6
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ori Liel <oliel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list