Change in ovirt-engine[master]: webadmin: there are no such things as ghost in MacRangeWidget

tjelinek at redhat.com tjelinek at redhat.com
Tue Sep 22 14:24:43 UTC 2015


Tomas Jelinek has submitted this change and it was merged.

Change subject: webadmin: there are no such things as ghost in MacRangeWidget
......................................................................


webadmin: there are no such things as ghost in MacRangeWidget

'isGhost' mechanism is faulty. Correct behavior is, acording to
colleges and code notes, that there's at most one ghost and it has to
be the last record. Currently implementation allows existence of
multiple ghosts, which needs not to be trailing records.

For simplicity, in this dialog we assume that there cannot exist
ghosts, until ghost problem is solved generally

Change-Id: I8091cedfd3cf51dfcb93bb7c7de45234088bfdd8
Bug-Url: https://bugzilla.redhat.com/1217940
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/macpool/MacRangeWidget.java
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Martin Mucha: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/46017
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8091cedfd3cf51dfcb93bb7c7de45234088bfdd8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list