Change in ovirt-engine[master]: restapi: Use elements instead of attributes in IP address

juan.hernandez at redhat.com juan.hernandez at redhat.com
Tue Sep 22 16:55:10 UTC 2015


Juan Hernandez has submitted this change and it was merged.

Change subject: restapi: Use elements instead of attributes in IP address
......................................................................


restapi: Use elements instead of attributes in IP address

Currently the IP address element uses attributes for its properties:

  <ip address="192.168.122.1" netmask="255.255.255.0"/>

This is contrary to the common practice in the RESTAPI. This patch
replaces them with inner elements:

  <ip>
    <address>192.168.122.1</address>
    <netmask>255.255.255.0</netmask>
  </ip>

Change-Id: I65e092d062b90b2fd7d90eb7ff988ffe83089773
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/modules/restapi/README.md
M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd
2 files changed, 20 insertions(+), 4 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/46060
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I65e092d062b90b2fd7d90eb7ff988ffe83089773
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ori Liel <oliel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list