Change in ovirt-engine[master]: restapi: Check result of "listFiles" in "PackageExplore"

juan.hernandez at redhat.com juan.hernandez at redhat.com
Wed Sep 23 14:27:49 UTC 2015


Juan Hernandez has submitted this change and it was merged.

Change subject: restapi: Check result of "listFiles" in "PackageExplore"
......................................................................


restapi: Check result of "listFiles" in "PackageExplore"

This is needed in order to avoid the following findbugs warning:

  Possible null pointer dereference due to return value of called method

  The return value from a method is dereferenced without a null check,
  and the return value of that method is one that should generally be
  checked for null. This may lead to a NullPointerException when the
  code is executed.

  Bug kind and pattern: NP - NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE

Change-Id: I0c8f25ce6e248dd32ccbc52e510f79cab809e90d
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/PackageExplorer.java
1 file changed, 14 insertions(+), 10 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/46591
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0c8f25ce6e248dd32ccbc52e510f79cab809e90d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list