Change in ovirt-engine[master]: core: Add custom findbugs plugin

[juan.hernandez at redhat.com]

Juan Hernandez has submitted this change and it was merged.

Change subject: core: Add custom findbugs plugin
......................................................................


core: Add custom findbugs plugin

The version of the findbugs plugin that we currently use (version 2.5.2)
doesn't work correctly with Java 8, and new versions of the plugin don't
support multiple filters files, which we use everywhere. To avoid this
issue this patch introduces a custom Maven plugin that merges the
multiple filters file into one during runtime, and then executes the
findbugs plugin passing only one file. This way we can migrate to the
new version of find bugs and then to Java 8.

This patch also includes a "findbugs.sh" script that contains the
command required to run the custom plugin.

Change-Id: If136b2bbaeb0d53017ee8322c76772a226045f55
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
A build-tools-root/ovirt-findbugs-maven-plugin/pom.xml
A build-tools-root/ovirt-findbugs-maven-plugin/src/main/java/org/ovirt/engine/findbugs/FindbugsMojo.java
M build-tools-root/pom.xml
A findbugs.sh
M ovirt-engine.spec.in
5 files changed, 508 insertions(+), 1 deletion(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/46402
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If136b2bbaeb0d53017ee8322c76772a226045f55
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: David Caro <dcaroest at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org