Change in ovirt-engine[master]: webadmin: Use Long.parseLong instead of boxing

juan.hernandez at redhat.com juan.hernandez at redhat.com
Wed Sep 23 18:55:31 UTC 2015


Juan Hernandez has submitted this change and it was merged.

Change subject: webadmin: Use Long.parseLong instead of boxing
......................................................................


webadmin: Use Long.parseLong instead of boxing

This is needed to avoid the following findbugs error:

  Boxing/unboxing to parse a primitive

  A boxed primitive is created from a String, just to extract the unboxed
  primitive value. It is more efficient to just call the static parseXXX
  method.

  Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING

Change-Id: I3eefebbca97be35e78794131ca3697d4b40059a3
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Juan Hernandez: Verified; Passed CI tests
  Alexander Wels: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/46549
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3eefebbca97be35e78794131ca3697d4b40059a3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list