Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Hotfix of icon validation for IE

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Thu Sep 24 08:35:54 UTC 2015


Piotr Kliczewski has submitted this change and it was merged.

Change subject: webadmin: Hotfix of icon validation for IE
......................................................................


webadmin: Hotfix of icon validation for IE

It disables part of client side icon validation on IE browsers. The
disabled part relies on parsing of images using <img> tag. IE parses
images asynchronously as opposed to Chrome or Firefox (after caching).
Current frontend validation assumes synchronous behavior.

There are still backend icon validations.

Change-Id: I2766e993c3e03b5a040a178e26b8b71c93ac585c
Bug-Url: https://bugzilla.redhat.com/1263994
Signed-off-by: Jakub Niedermertl <jniederm at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/IconValidation.java
1 file changed, 8 insertions(+), 1 deletion(-)

Approvals:
  Piotr Kliczewski: Passed CI tests
  Jakub Niedermertl: Verified
  Vojtech Szocs: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/46534
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2766e993c3e03b5a040a178e26b8b71c93ac585c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list