Change in ovirt-engine[master]: webadmin: Remove useless condition in "VmBrickModel.validate...

juan.hernandez at redhat.com juan.hernandez at redhat.com
Thu Sep 24 11:24:17 UTC 2015


Juan Hernandez has submitted this change and it was merged.

Change subject: webadmin: Remove useless condition in "VmBrickModel.validateBrickCount"
......................................................................


webadmin: Remove useless condition in "VmBrickModel.validateBrickCount"

This is necessary to avoid the following findbugs error:

  Condition has no effect

  This condition always produces the same result as the value of the
  involved variable was narrowed before. Probably something else was meant
  or condition can be removed.

  Bug kind and pattern: UC - UC_USELESS_CONDITION

Change-Id: I99bb4ac3912e250d1406d9426ada2c79d956a8b2
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Juan Hernandez: Verified; Passed CI tests
  Alexander Wels: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/46554
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I99bb4ac3912e250d1406d9426ada2c79d956a8b2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list