Change in ovirt-engine[master]: core: Use "Integer.compare" in "NegotiationFilter"

[juan.hernandez at redhat.com]

Juan Hernandez has submitted this change and it was merged.

Change subject: core: Use "Integer.compare" in "NegotiationFilter"
......................................................................


core: Use "Integer.compare" in "NegotiationFilter"

This is needed in order to avoid the following findbugs error:

  Boxing/unboxing to parse a primitive

  A boxed primitive is created from a String, just to extract the
  unboxed primitive value. It is more efficient to just call the static
  parseXXX method.

  Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING

Change-Id: If7b058cc3805e43cdf09d0ca9e534d2448738900
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Alon Bar-Lev: Looks good to me, but someone else must approve
  Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/46613
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If7b058cc3805e43cdf09d0ca9e534d2448738900
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: automation at ovirt.org