Change in ovirt-engine[master]: core: Check result of "list" in "Tar"

juan.hernandez at redhat.com juan.hernandez at redhat.com
Fri Sep 25 08:17:47 UTC 2015


Juan Hernandez has submitted this change and it was merged.

Change subject: core: Check result of "list" in "Tar"
......................................................................


core: Check result of "list" in "Tar"

This is needed in order to avoid the following findbugs warning:

  Possible null pointer dereference due to return value of called method

  The return value from a method is dereferenced without a null check,
  and the return value of that method is one that should generally be
  checked for null. This may lead to a NullPointerException when the
  code is executed.

  Bug kind and pattern: NP - NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE

Change-Id: I942994dc5d9d5e4470a4a8f28903807c820c071d
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/archivers/tar/Tar.java
1 file changed, 9 insertions(+), 6 deletions(-)

Approvals:
  Alon Bar-Lev: Looks good to me, but someone else must approve
  Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/46597
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I942994dc5d9d5e4470a4a8f28903807c820c071d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list