Change in ovirt-engine[master]: core: Use "Integer.parseInt" in "VmDeviceType"

juan.hernandez at redhat.com juan.hernandez at redhat.com
Fri Sep 25 08:25:19 UTC 2015


Juan Hernandez has submitted this change and it was merged.

Change subject: core: Use "Integer.parseInt" in "VmDeviceType"
......................................................................


core: Use "Integer.parseInt" in "VmDeviceType"

This is needed in order to avoid the following findbugs error:

  Boxing/unboxing to parse a primitive

  A boxed primitive is created from a String, just to extract the
  unboxed primitive value. It is more efficient to just call the static
  parseXXX method.

  Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING

Change-Id: I214defcc26e08353e1aa4d414302cca214fce688
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceType.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/46583
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I214defcc26e08353e1aa4d414302cca214fce688
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list