Change in ovirt-engine[master]: core: ConnectAllHostsToLunCommand#createReturnValue

tnisan at redhat.com tnisan at redhat.com
Sun Sep 27 09:03:32 UTC 2015


Tal Nisan has submitted this change and it was merged.

Change subject: core: ConnectAllHostsToLunCommand#createReturnValue
......................................................................


core: ConnectAllHostsToLunCommand#createReturnValue

The whole point of overriding this method is using a different return
value. This patch makes it explicit by specifying the return type
accordingly, in order to improve the code's readability.

Change-Id: Id73db450e19b6a9836df893693cd2bb125e08223
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified
  Freddy Rolland: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/46434
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id73db450e19b6a9836df893693cd2bb125e08223
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list