Change in ovirt-engine[master]: core: Async tasks - move steps/jobs handling to CommandBase

laravot at redhat.com laravot at redhat.com
Tue Apr 5 12:51:49 UTC 2016


Liron Aravot has submitted this change and it was merged.

Change subject: core: Async tasks - move steps/jobs handling to CommandBase
......................................................................


core: Async tasks - move steps/jobs handling to CommandBase

Currently the tasks related jobs/steps handling logic is within
CommandAsyncTask. When using CoCo to track task related commands we'll
sometimes want the child command endAction() to be executed by the parent
command, in that case the jobs/steps logic won't be executed as the related
code is in CommandAsyncTask.

This patch moves that code to the endAction() in CommandBase, so when having
a CoCo managed flow the behavior will remain the same.

Change-Id: I5836dbd3c6e3ff69fc1776471457affd9aa582f8
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1310426
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandAsyncTask.java
2 files changed, 21 insertions(+), 9 deletions(-)

Approvals:
  Freddy Rolland: Looks good to me, but someone else must approve
  Moti Asayag: Looks good to me, approved
  Liron Aravot: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/55614
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5836dbd3c6e3ff69fc1776471457affd9aa582f8
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list