Change in ovirt-engine[master]: core: remove redundant unlock call in image upload failure.

derez at redhat.com derez at redhat.com
Thu Apr 7 07:32:58 UTC 2016


Daniel Erez has submitted this change and it was merged.

Change subject: core: remove redundant unlock call in image upload failure.
......................................................................


core: remove redundant unlock call in image upload failure.

In BaseImagesCommand, Calling unLockImage() only calls
setImageStatus(ImageStatus.OK). since in image upload failure handling
we are calling setImageStatus(ImageStatus.ILLEGAL) right after
unLockImage(), there is no point calling unLockImage().

Change-Id: I12f9dc64e1ef14d655120251334ea1dc0be74c77
Signed-off-by: Amit Aviram <aaviram at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Daniel Erez: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Amit Aviram: Verified



-- 
To view, visit https://gerrit.ovirt.org/55624
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I12f9dc64e1ef14d655120251334ea1dc0be74c77
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list