Change in ovirt-engine[master]: core: fix AuditLogDaoTest

mperina at redhat.com mperina at redhat.com
Thu Apr 7 14:54:36 UTC 2016


Martin Peřina has submitted this change and it was merged.

Change subject: core: fix AuditLogDaoTest
......................................................................


core: fix AuditLogDaoTest

This cause of that is https://gerrit.ovirt.org/#/c/55724/ but actually
the fixtures.xml is corrupted and the merge of the above patch
discovered that.

The audit_log table in fixtures.xml must apply that if audit_log_id of
record X > audit_log_id of record Y then the log_time of record X >
log_time of record Y.

The fixtures.xml file does not apply this simple rulem thus the "delete
before/after" tests are not working

Solution is to rearrange the fixtures.xml to apply the above rule and
make the relevant changes in the test

Change-Id: I67bf6b7a7316d8529b8f1eaafa1d54132dc3eec6
Signed-off-by: emesika <emesika at redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AuditLogDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
2 files changed, 77 insertions(+), 77 deletions(-)

Approvals:
  Martin Peřina: Looks good to me, approved
  Eli Mesika: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/55813
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I67bf6b7a7316d8529b8f1eaafa1d54132dc3eec6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list