Change in ovirt-engine[master]: core: Make VmValidator validate single VMs

tnisan at redhat.com tnisan at redhat.com
Mon Apr 11 13:47:00 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: Make VmValidator validate single VMs
......................................................................


core: Make VmValidator validate single VMs

As all methods in VmValidator are validating a single VM, the support for
multiple VMs is overkill and adds unnecessary complexity to every
validation that has to be added to this class.
This patch make VmValidator test single VMs, for future multiple VM
validations there's the MultipleVmsValdator class

Change-Id: I84db7fcc79893f8b88d3dd0016adc514e5008869
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java
1 file changed, 51 insertions(+), 82 deletions(-)

Approvals:
  Tal Nisan: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/55712
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I84db7fcc79893f8b88d3dd0016adc514e5008869
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list