Change in ovirt-engine[master]: core: extract vmNotHavingPluggedDiskSnapshots from VmValidator

tnisan at redhat.com tnisan at redhat.com
Mon Apr 11 13:47:00 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: extract vmNotHavingPluggedDiskSnapshots from VmValidator
......................................................................


core: extract vmNotHavingPluggedDiskSnapshots from VmValidator

As vmNotHavingPluggedDiskSnapshots is the only method in VmValidator used
to validate a collection of VMs it was exctract to a new validator class
named MultipleVmsValdator which will handle validations on multiple VMs

Change-Id: I451d4c56dcf63a310b70d79159aab6a9adc79b52
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/MultipleVmsValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java
4 files changed, 61 insertions(+), 39 deletions(-)

Approvals:
  Tal Nisan: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/55710
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I451d4c56dcf63a310b70d79159aab6a9adc79b52
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list