Change in ovirt-engine[master]: engine: Adding read-only check in ExternalNetworkProviderProxy

alkaplan at redhat.com alkaplan at redhat.com
Thu Apr 14 09:30:52 UTC 2016


Alona Kaplan has submitted this change and it was merged.

Change subject: engine: Adding read-only check in ExternalNetworkProviderProxy
......................................................................


engine: Adding read-only check in ExternalNetworkProviderProxy

Adding a check against the read only attribute.
The check is actually doubled, as the check is (should be)
made in the appropriate Actions, where a better error message
is provided.

Change-Id: If46d14c09e1743ae0553d364917c1a4cdae900c4
Signed-off-by: mirecki <mmirecki at redhat.com>
Bug-Url: https://bugzilla.redhat.com/1314375
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/BaseNetworkProviderProxy.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/ExternalNetworkProviderProxy.java
2 files changed, 39 insertions(+), 1 deletion(-)

Approvals:
  Marcin Mirecki: Verified
  Martin Mucha: Looks good to me, but someone else must approve
  Alona Kaplan: Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/55263
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If46d14c09e1743ae0553d364917c1a4cdae900c4
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list