Change in ovirt-engine[master]: restapi: Error hangling in BackendVmGraphicsConsoleResource

[tjelinek at redhat.com]

Tomas Jelinek has submitted this change and it was merged.

Change subject: restapi: Error hangling in BackendVmGraphicsConsoleResource
......................................................................


restapi: Error hangling in BackendVmGraphicsConsoleResource

The patch handles possible failure of ConfigureConsoleOptionsQuery
called from method #generateDescriptor(). It may fail due to
insufficient permissions. Standard error reporting can't be used here
because it produces an explanatory reponse body and there is no
MessageBodyWriter for 'application/x-virt-viewer' content type. Thus it
would procude a HTML stacktrace about missing MessageBodyWriter.

The error is logged and reported to client only using status code 500.
Response body is empty.

Change-Id: I1a22ba4f998dd317348393e6292614aedae3b8ec
Bug-Url: https://bugzilla.redhat.com/1305600
Signed-off-by: Jakub Niedermertl <jniederm at redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmGraphicsConsoleResource.java
1 file changed, 16 insertions(+), 5 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Jakub Niedermertl: Verified
  Juan Hernandez: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/53243
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1a22ba4f998dd317348393e6292614aedae3b8ec
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>