Change in ovirt-engine[master]: core: Make setup method in HotPlugDiskToVmCommandTest more r...

tnisan at redhat.com tnisan at redhat.com
Wed Apr 20 17:14:58 UTC 2016


Tal Nisan has submitted this change and it was merged.

Change subject: core: Make setup method in HotPlugDiskToVmCommandTest more readable
......................................................................


core: Make setup method in HotPlugDiskToVmCommandTest more readable

Use @Mock instead of manual mocks, separate blocks that handle different
mock behaviors to make the setup method more readable

Change-Id: Ia8f14326e5098ae07dd1c6cb955fa18cfef9d372
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommandTest.java
1 file changed, 10 insertions(+), 3 deletions(-)

Approvals:
  Tal Nisan: Verified
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/56420
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8f14326e5098ae07dd1c6cb955fa18cfef9d372
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list