Change in ovirt-engine-sdk[master]: Move connection class to "ovirtsdk4" module

juan.hernandez at redhat.com juan.hernandez at redhat.com
Thu Apr 28 08:14:06 UTC 2016


Juan Hernandez has submitted this change and it was merged.

Change subject: Move connection class to "ovirtsdk4" module
......................................................................


Move connection class to "ovirtsdk4" module

Currently the "Connection" and "ConnectionBuilder" classes are part of
the "ovirtsdk4.http" module, but then the classes are imported from the
"ovitsdk4" module so that the user can just "import ovirtsdk4". But this
has the downside that tools that automatically generate documentation
will generate it under "ovirtsdk4.http", which can be confusing for
users. To avoid this potential source of confusion this patch moves the
"Connection" and "ConnnectionBuilder" classes to the "__init__.py" file
of the "ovirtsdk4" module.

Change-Id: Ia79b93b2e510a39af1592e0886ee958f5e90f5a7
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M sdk/lib/ovirtsdk4/__init__.py
M sdk/lib/ovirtsdk4/http.py
2 files changed, 561 insertions(+), 565 deletions(-)

Approvals:
  Ondra Machacek: Looks good to me, but someone else must approve
  Juan Hernandez: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/56680
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia79b93b2e510a39af1592e0886ee958f5e90f5a7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list