Change in ovirt-engine[master]: core: List and Map instead of ArrayList and HashMap in OsRep...

ahadas at redhat.com ahadas at redhat.com
Thu Apr 28 13:31:14 UTC 2016


Arik Hadas has submitted this change and it was merged.

Change subject: core: List and Map instead of ArrayList and HashMap in OsRepository
......................................................................


core: List and Map instead of ArrayList and HashMap in OsRepository

Use List and Map interfaces as return values of OsRepository methods
instead of ArrayList and HashMap classes. Also removed redundant
specifiers from interface's methods and fields.

Change-Id: I50f2b9edc29625903fcd04ae72228e5e347daf69
Signed-off-by: Shmuel Melamud <smelamud at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IconLoader.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendOperatingSystemsResource.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OsRepositoryImplTest.java
5 files changed, 63 insertions(+), 67 deletions(-)

Approvals:
  Juan Hernandez: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Shmuel Leib Melamud: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/56678
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I50f2b9edc29625903fcd04ae72228e5e347daf69
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list