Change in ovirt-engine[master]: webadmin:rename "SSL Verification" field

tjelinek at redhat.com tjelinek at redhat.com
Mon Aug 1 07:47:21 UTC 2016


Tomas Jelinek has submitted this change and it was merged.

Change subject: webadmin:rename "SSL Verification" field
......................................................................


webadmin:rename "SSL Verification" field

Rename "SSL Verification" checkbox field to
"verify server's SSL certificate" since it's more understandable
and also change the checkbox default value to checked.

Import from VMware provider uses the "SSL verification" check box to
determine if to add the "no_verify="1" flag to the URI or not:
1. if this checkox is checked (default) then the "no_verify=1" flag is not
added to the URI and a verification of the server's SSL certificate is
done.

2. If this checkbox is not checked then the "no_verify=1' flag is
added automatically to the URI and no VMware server's SSL certificate is
verified.

The current field is renamed to: "verify server's SSL
certificate".

The field renaming and default change is done for both
"Add/edit Provider" dialog (VMwarePropertiesWidget) and for Import
VMs dialog.

Change-Id: I4134da4f76e95354c0c980f31f4cb5a7b6d1d3cf
Bug-Url: https://bugzilla.redhat.com/1361193
Signed-off-by: Sharon Gratch <sgratch at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/VmwarePropertiesModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/VmwarePropertiesWidget.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties
7 files changed, 16 insertions(+), 9 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Sharon Gratch: Verified



-- 
To view, visit https://gerrit.ovirt.org/61660
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4134da4f76e95354c0c980f31f4cb5a7b6d1d3cf
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list