Change in ovirt-engine[master]: core: reduce number of nested levels in VmDevicesMonitoring#...

ahadas at redhat.com ahadas at redhat.com
Thu Aug 4 14:26:59 UTC 2016


Arik Hadas has submitted this change and it was merged.

Change subject: core: reduce number of nested levels in VmDevicesMonitoring#flush
......................................................................


core: reduce number of nested levels in VmDevicesMonitoring#flush

Since most of the code in this method should be inside a try block so
the unlock of the VMs would be inside a finally block, this patch
reduces the number of nested level in this method so it would be
easier to read.

Change-Id: I758127759083585f584e346edc6c33affb8965fe
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java
1 file changed, 3 insertions(+), 6 deletions(-)

Approvals:
  Shahar Havivi: Looks good to me, approved
  Arik Hadas: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/61911
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I758127759083585f584e346edc6c33affb8965fe
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Sharon Gratch <sgratch at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list