Change in ovirt-engine[master]: packaging: drop FIX_RELEASE handling

sbonazzo at redhat.com sbonazzo at redhat.com
Fri Aug 5 11:10:28 UTC 2016


Sandro Bonazzola has submitted this change and it was merged.

Change subject: packaging: drop FIX_RELEASE handling
......................................................................


packaging: drop FIX_RELEASE handling

When FIX_RELEASE was added to version.mak, the intention
was to allow to release an ovirt-engine package without
any modification to the java code, allowing to avoid to
bump the version in the pom files.

The intention was good but as per package maintenance we
keep aligned pom version and package version anyway when
we release. FIX_RELEASE has become meaningless and source
of human errors, therefore we're dropping it.

That done, POM_VERSION, APP_VERSION and RPM_VERSION
became redundant, dropped all of them and using the
unique value ENGINE_VERSION.
Kept only PACKAGE_VERSION which differ by the MILESTONE
suffix.

Change-Id: I4ff946551dc52d4a278976fa1cd049697c7496a3
Bug-Url: https://bugzilla.redhat.com/1354180
Signed-off-by: Sandro Bonazzola <sbonazzo at redhat.com>
---
M Makefile
M version.mak
2 files changed, 4 insertions(+), 13 deletions(-)

Approvals:
  Sandro Bonazzola: Verified; Looks good to me, approved
  Martin Peřina: Looks good to me, but someone else must approve
  Juan Hernandez: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Rafael Martins: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/61949
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4ff946551dc52d4a278976fa1cd049697c7496a3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Rafael Martins <rmartins at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list