Change in ovirt-engine[master]: engine: RM MultilevelAdministrationsQueriesParameters

amureini at redhat.com amureini at redhat.com
Mon Aug 8 14:55:20 UTC 2016


Allon Mureinik has submitted this change and it was merged.

Change subject: engine: RM MultilevelAdministrationsQueriesParameters
......................................................................


engine: RM MultilevelAdministrationsQueriesParameters

MultilevelAdministrationsQueriesParameters has no state, making it
useless. There's no reason not to just use VdcQueryParametersBase
directly.

This patch removes this useless class and refines all its usages.

Change-Id: Ib6f0ff846908c179fc8157c562d63a27b2ce1cd5
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllRolesQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllRolesQueryTest.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/MultilevelAdministrationsQueriesParameters.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendRolesResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendRolesResourceTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleListModel.java
7 files changed, 12 insertions(+), 22 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Martin Peřina: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/62066
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6f0ff846908c179fc8157c562d63a27b2ce1cd5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Ori Liel <oliel at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list