Change in ovirt-engine[master]: engine: Fix taskhandler init - RemoveDisksSnapshot

derez at redhat.com derez at redhat.com
Thu Aug 11 07:03:53 UTC 2016


Daniel Erez has submitted this change and it was merged.

Change subject: engine: Fix taskhandler init - RemoveDisksSnapshot
......................................................................


engine: Fix taskhandler init - RemoveDisksSnapshot

The method initTaskHandlers is called every time that the command is
initiated.

In RemoveDiskSnapshotsCommand, the number of task handlers created was
different after that the former handler finished its operation.
This situation created a mismatch between the task handler map in
BaseCommand and the command execution index.

In this patch, the images IDs are computed only once and not every time
that the initTaskHandlers is invoked, keeping the number of task
handlers consistent.

Also, the task handlers are not created if it is a live merge flow.

Change-Id: Ic2836d7f6430183eecef337ed6d1c667b2f2990c
Bug-Url: https://bugzilla.redhat.com/1365393
Signed-off-by: Fred Rolland <frolland at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommand.java
1 file changed, 7 insertions(+), 17 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Daniel Erez: Looks good to me, approved
  Allon Mureinik: Looks good to me, but someone else must approve
  Freddy Rolland: Verified



-- 
To view, visit https://gerrit.ovirt.org/62158
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2836d7f6430183eecef337ed6d1c667b2f2990c
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list