Change in ovirt-engine-sdk-ruby[master]: Add support for secondary parameters

juan.hernandez at redhat.com juan.hernandez at redhat.com
Thu Aug 18 14:42:08 UTC 2016


Juan Hernandez has submitted this change and it was merged.

Change subject: Add support for secondary parameters
......................................................................


Add support for secondary parameters

The "add" and "update" methods support one primary parameter that
corresponds to the HTTP request body, and multiple secondary parameters
that correspond to URL query parameters. For example, the method to add
a virtual machine looks has the primary "vm" parameter, and also the
"clone" secondary parameters. Currently secondary parameters aren't
supported by the SDK, they are just ignored. This patch adds support for
those parameters.

Change-Id: I24188c5107950c29467d31b81337f9703a0c2e46
Bug-Url: https://bugzilla.redhat.com/1366548
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java
A sdk/examples/add_independent_vm.rb
M sdk/spec/spec_helper.rb
M sdk/spec/vms_service_spec.rb
4 files changed, 230 insertions(+), 62 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/62462
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I24188c5107950c29467d31b81337f9703a0c2e46
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list